From 4eb0047ad118acc617782392c4dda87f5c016f86 Mon Sep 17 00:00:00 2001
From: Joe Forbes <forbesjo@users.noreply.github.com>
Date: Wed, 3 Jan 2018 16:58:23 -0500
Subject: [PATCH] fix: wrap audio change handler rather than bind so a player
dispose doesn't affect other players (#4847)
---
.../audio-track-controls/audio-track-menu-item.js | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/src/js/control-bar/audio-track-controls/audio-track-menu-item.js b/src/js/control-bar/audio-track-controls/audio-track-menu-item.js
index 50035056..64ea19dc 100644
--- a/src/js/control-bar/audio-track-controls/audio-track-menu-item.js
+++ b/src/js/control-bar/audio-track-controls/audio-track-menu-item.js
@@ -3,7 +3,6 @@
*/
import MenuItem from '../../menu/menu-item.js';
import Component from '../../component.js';
-import * as Fn from '../../utils/fn.js';
/**
* An {@link AudioTrack} {@link MenuItem}
@@ -33,7 +32,9 @@ class AudioTrackMenuItem extends MenuItem {
this.track = track;
- const changeHandler = Fn.bind(this, this.handleTracksChange);
+ const changeHandler = (...args) => {
+ this.handleTracksChange.apply(this, args);
+ };
tracks.addEventListener('change', changeHandler);
this.on('dispose', () => {
--
GitLab